Skip to content

fix: handle empty input#11845

Open
bhumikasudarshani-cmd wants to merge 2 commits intostdlib-js:developfrom
bhumikasudarshani-cmd:fix/lint-issue-11784
Open

fix: handle empty input#11845
bhumikasudarshani-cmd wants to merge 2 commits intostdlib-js:developfrom
bhumikasudarshani-cmd:fix/lint-issue-11784

Conversation

@bhumikasudarshani-cmd
Copy link
Copy Markdown
Contributor

@bhumikasudarshani-cmd bhumikasudarshani-cmd commented Apr 29, 2026

Description

This PR fixes a JavaScript lint error in @stdlib/ndarray/base/unary-by.

Changes

  • Added @stdlib/string/format import in lib/main.js
  • Replaced string concatenation in error message with format() as required by the stdlib/no-error-string-concat ESLint rule

Related Issues

Related to #11784

@bhumikasudarshani-cmd bhumikasudarshani-cmd requested a review from a team April 29, 2026 17:15
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Apr 29, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/base/dgemv $\color{red}748/749$
$\color{green}+99.87%$
$\color{red}116/117$
$\color{green}+99.15%$
$\color{green}6/6$
$\color{green}+100.00%$
$\color{red}748/749$
$\color{green}+99.87%$
ndarray/base/unary-by $\color{red}5062/11150$
$\color{green}+45.40%$
$\color{green}44/44$
$\color{green}+100.00%$
$\color{red}0/43$
$\color{green}+0.00%$
$\color{red}5062/11150$
$\color{green}+45.40%$

The above coverage report was generated for the changes in this PR.

@bhumikasudarshani-cmd bhumikasudarshani-cmd changed the title Fix JavaScript lint errors fix: handle empty input Apr 29, 2026
Copy link
Copy Markdown
Member

⚠️ Issue Reference Review

An automated check found a potentially unrelated issue/PR reference in this PR:

Reference Assessment Reasoning
#11784 suspicious PR title is "fix: handle empty input" and coverage shows logic changes in blas/base/dgemv and ndarray/base/unary-by, but issue #11784 ("Fix JavaScript lint errors") describes a CI crash in _tools/github/create-issue/lib/query.js due to RangeError: Invalid time value. The PR description does claim to fix a lint error in ndarray/base/unary-by, but the connection between an "empty input" logic fix and the lint-runner crash in the issue is not immediately clear.

Why this matters: GitHub automatically closes issues referenced with closing keywords (Resolves, Closes, Fixes) when the PR is merged. If this reference is incorrect, merging will permanently close issue #11784 before the underlying lint-runner problem is fully addressed.

What to do:

  • If the reference is correct (e.g., fixing empty-input handling in ndarray/base/unary-by resolves the reported lint failure), no action needed. This check may produce false positives.
  • If the reference is incorrect, please update your PR description to remove or correct the closing keyword.

This assessment was generated by an AI model and is informational only.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants